Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1808053002:
Fix sense of CheckOpResult comment. (Closed)
DescriptionFix sense of CheckOpResult comment.
Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be
Cr-Commit-Position: refs/heads/master@{#382056}
Committed: https://crrev.com/f01a9b7d35e1140317e824a7df39aa1cb15c6963
Cr-Commit-Position: refs/heads/master@{#382167}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Revert iff->if and only if #Messages
Total messages: 19 (9 generated)
wez@chromium.org changed reviewers: + danakj@chromium.org
PTAL - tiny comment correction.
LGTM
The CQ bit was checked by wez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808053002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix sense of CheckOpResult comment. ========== to ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056}
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
Thanks for this! https://codereview.chromium.org/1808053002/diff/1/base/logging.h File base/logging.h (right): https://codereview.chromium.org/1808053002/diff/1/base/logging.h#newcode433 base/logging.h:433: // |message| must be non-null iff the check failed. Let's please not say "iff" in chromium code. "if and only if" says the same thing without being heinous. We don't say this so often that we need to shorten it to three letters.
Message was sent while issue was closed.
Description was changed from ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ========== to ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ==========
The CQ bit was checked by wez@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/1808053002/#ps20001 (title: "Revert iff->if and only if")
https://codereview.chromium.org/1808053002/diff/1/base/logging.h File base/logging.h (right): https://codereview.chromium.org/1808053002/diff/1/base/logging.h#newcode433 base/logging.h:433: // |message| must be non-null iff the check failed. On 2016/03/18 21:56:48, Nico wrote: > Let's please not say "iff" in chromium code. "if and only if" says the same > thing without being heinous. We don't say this so often that we need to shorten > it to three letters. I think it's a bit much to describe the standard shorthand for "if and only if" as "heinous"... Nonetheless, expanded back out to more bodacious wording. ;)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808053002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ========== to ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} ========== to ========== Fix sense of CheckOpResult comment. Committed: https://crrev.com/b7662fc32246dda98df64fd8aa41fddbaae7d2be Cr-Commit-Position: refs/heads/master@{#382056} Committed: https://crrev.com/f01a9b7d35e1140317e824a7df39aa1cb15c6963 Cr-Commit-Position: refs/heads/master@{#382167} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f01a9b7d35e1140317e824a7df39aa1cb15c6963 Cr-Commit-Position: refs/heads/master@{#382167} |
