Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 180803012: Disable some compositing state asserts seen on Mac builds (Closed)

Created:
6 years, 9 months ago by Rick Byers
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Disable some compositing state asserts seen on Mac builds Test scenarios: http://www.rbyers.net/eventTest.html - scrolling the page or div (has a wheel handler but doesn't call preventDefault) Loading https://twitter.com/pwnall BUG=343132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/core/rendering/RenderBox.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Rick Byers
Ojan, Please take a look. I didn't dig into these in any detail to try ...
6 years, 9 months ago (2014-03-04 21:34:26 UTC) #1
ojan
lgtm Would be nice to commit reduced versions of those pages along with this patch. ...
6 years, 9 months ago (2014-03-05 02:55:51 UTC) #2
Rick Byers
The CQ bit was checked by rbyers@chromium.org
6 years, 9 months ago (2014-03-05 02:57:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/180803012/1
6 years, 9 months ago (2014-03-05 02:57:51 UTC) #4
Rick Byers
On 2014/03/05 02:55:51, ojan wrote: > lgtm > > Would be nice to commit reduced ...
6 years, 9 months ago (2014-03-05 03:25:03 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 14:09:28 UTC) #6
Message was sent while issue was closed.
Change committed as 168478

Powered by Google App Engine
This is Rietveld 408576698