Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 180803010: MIPS: Remove all uses of field-tracking flags that do not make decisions but are subject to existin… (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved.7 1 // Copyright 2012 the V8 project authors. All rights reserved.7
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3969 matching lines...) Expand 10 before | Expand all | Expand 10 after
3980 MemOperand operand = MemOperand(object, offset); 3980 MemOperand operand = MemOperand(object, offset);
3981 __ Store(value, operand, representation); 3981 __ Store(value, operand, representation);
3982 return; 3982 return;
3983 } 3983 }
3984 3984
3985 Handle<Map> transition = instr->transition(); 3985 Handle<Map> transition = instr->transition();
3986 SmiCheck check_needed = 3986 SmiCheck check_needed =
3987 instr->hydrogen()->value()->IsHeapObject() 3987 instr->hydrogen()->value()->IsHeapObject()
3988 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK; 3988 ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
3989 3989
3990 if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { 3990 if (representation.IsHeapObject()) {
3991 Register value = ToRegister(instr->value()); 3991 Register value = ToRegister(instr->value());
3992 if (!instr->hydrogen()->value()->type().IsHeapObject()) { 3992 if (!instr->hydrogen()->value()->type().IsHeapObject()) {
3993 __ SmiTst(value, scratch); 3993 __ SmiTst(value, scratch);
3994 DeoptimizeIf(eq, instr->environment(), scratch, Operand(zero_reg)); 3994 DeoptimizeIf(eq, instr->environment(), scratch, Operand(zero_reg));
3995 3995
3996 // We know that value is a smi now, so we can omit the check below. 3996 // We know that value is a smi now, so we can omit the check below.
3997 check_needed = OMIT_SMI_CHECK; 3997 check_needed = OMIT_SMI_CHECK;
3998 } 3998 }
3999 } else if (representation.IsDouble()) { 3999 } else if (representation.IsDouble()) {
4000 ASSERT(transition.is_null()); 4000 ASSERT(transition.is_null());
(...skipping 1752 matching lines...) Expand 10 before | Expand all | Expand 10 after
5753 __ Subu(scratch, result, scratch); 5753 __ Subu(scratch, result, scratch);
5754 __ lw(result, FieldMemOperand(scratch, 5754 __ lw(result, FieldMemOperand(scratch,
5755 FixedArray::kHeaderSize - kPointerSize)); 5755 FixedArray::kHeaderSize - kPointerSize));
5756 __ bind(&done); 5756 __ bind(&done);
5757 } 5757 }
5758 5758
5759 5759
5760 #undef __ 5760 #undef __
5761 5761
5762 } } // namespace v8::internal 5762 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698