Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 180803010: MIPS: Remove all uses of field-tracking flags that do not make decisions but are subject to existin… (Closed) Base URL: https://github.com/v8/v8.git@gbl
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1644 matching lines...) Expand 10 before | Expand all | Expand 10 after
1655 __ li(a2, Operand(Smi::FromInt(expr->literal_index()))); 1655 __ li(a2, Operand(Smi::FromInt(expr->literal_index())));
1656 __ li(a1, Operand(constant_properties)); 1656 __ li(a1, Operand(constant_properties));
1657 int flags = expr->fast_elements() 1657 int flags = expr->fast_elements()
1658 ? ObjectLiteral::kFastElements 1658 ? ObjectLiteral::kFastElements
1659 : ObjectLiteral::kNoFlags; 1659 : ObjectLiteral::kNoFlags;
1660 flags |= expr->has_function() 1660 flags |= expr->has_function()
1661 ? ObjectLiteral::kHasFunction 1661 ? ObjectLiteral::kHasFunction
1662 : ObjectLiteral::kNoFlags; 1662 : ObjectLiteral::kNoFlags;
1663 __ li(a0, Operand(Smi::FromInt(flags))); 1663 __ li(a0, Operand(Smi::FromInt(flags)));
1664 int properties_count = constant_properties->length() / 2; 1664 int properties_count = constant_properties->length() / 2;
1665 if ((FLAG_track_double_fields && expr->may_store_doubles()) || 1665 if (expr->may_store_doubles() || expr->depth() > 1 || Serializer::enabled() ||
1666 expr->depth() > 1 || Serializer::enabled() ||
1667 flags != ObjectLiteral::kFastElements || 1666 flags != ObjectLiteral::kFastElements ||
1668 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) { 1667 properties_count > FastCloneShallowObjectStub::kMaximumClonedProperties) {
1669 __ Push(a3, a2, a1, a0); 1668 __ Push(a3, a2, a1, a0);
1670 __ CallRuntime(Runtime::kCreateObjectLiteral, 4); 1669 __ CallRuntime(Runtime::kCreateObjectLiteral, 4);
1671 } else { 1670 } else {
1672 FastCloneShallowObjectStub stub(properties_count); 1671 FastCloneShallowObjectStub stub(properties_count);
1673 __ CallStub(&stub); 1672 __ CallStub(&stub);
1674 } 1673 }
1675 1674
1676 // If result_saved is true the result is on top of the stack. If 1675 // If result_saved is true the result is on top of the stack. If
(...skipping 3290 matching lines...) Expand 10 before | Expand all | Expand 10 after
4967 Assembler::target_address_at(pc_immediate_load_address)) == 4966 Assembler::target_address_at(pc_immediate_load_address)) ==
4968 reinterpret_cast<uint32_t>( 4967 reinterpret_cast<uint32_t>(
4969 isolate->builtins()->OsrAfterStackCheck()->entry())); 4968 isolate->builtins()->OsrAfterStackCheck()->entry()));
4970 return OSR_AFTER_STACK_CHECK; 4969 return OSR_AFTER_STACK_CHECK;
4971 } 4970 }
4972 4971
4973 4972
4974 } } // namespace v8::internal 4973 } } // namespace v8::internal
4975 4974
4976 #endif // V8_TARGET_ARCH_MIPS 4975 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698