Issue 180803004: Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable

Issue 180803004: Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable (Closed)

Created:
6 years, 9 months ago by apavlov

Modified:
6 years, 9 months ago

Reviewers:
hajimehoshi, dmazzoni, jochen (gone - plz use gerrit), kouhei (in TOK)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, tfarina, haraken

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable (https://codereview.chromium.org/172263002/) Reason for revert: Tentatively resulted in V8 crashes for fast/dom/custom/document-register-reentrant-throwing-constructor.html, fast/events/before-unload-return-bad-value.html, fast/events/onerror-no-constructor.html Original issue's description: > Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable > > BUG=297480, 331301 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253821 TBR=jochen@chromium.org,kouhei@chromium.org,dmazzoni@chromium.org,hajimehoshi@chromium.org NOTREECHECKS=true NOTRY=true BUG=297480, 331301 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253848

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1600 lines, -1613 lines)			Patch
M	content/content_shell.gypi	View	3 chunks	+4 lines, -5 lines	0 comments	Download
A	content/shell/renderer/test_runner/AccessibilityController.h	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/AccessibilityController.cpp	View	1 chunk	+184 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/TestInterfaces.cpp	View	8 chunks	+9 lines, -9 lines	0 comments	Download
A	content/shell/renderer/test_runner/WebAXObjectProxy.h	View	1 chunk	+146 lines, -0 lines	0 comments	Download
A	content/shell/renderer/test_runner/WebAXObjectProxy.cpp	View	1 chunk	+1178 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/WebTestProxy.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
D	content/shell/renderer/test_runner/accessibility_controller.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
D	content/shell/renderer/test_runner/accessibility_controller.cc	View	1 chunk	+0 lines, -272 lines	0 comments	Download
D	content/shell/renderer/test_runner/unsafe_persistent.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	content/shell/renderer/test_runner/web_ax_object_proxy.h	View	1 chunk	+0 lines, -168 lines	0 comments	Download
D	content/shell/renderer/test_runner/web_ax_object_proxy.cc	View	1 chunk	+0 lines, -1024 lines	0 comments	Download

Total messages: 3 (0 generated)

apavlov

Created Revert of Move WebAXObjectProxy and AccessibleController from CppBoundClass to gin::Wrappable

6 years, 9 months ago (2014-02-27 17:12:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/180803004/1

6 years, 9 months ago (2014-02-27 17:13:38 UTC) #2

Message was sent while issue was closed.

Change committed as 253848