|
|
DescriptionUpdate Dr. Memory to 0x4c19296, (release 1.10.0)
TBR=bruening@chromium.org, oshima@chromium.org
BUG=
Committed: https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c
Cr-Commit-Position: refs/heads/master@{#381635}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
The CQ bit was checked by zhaoqin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808023003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org BUG= ========== to ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= ==========
zhaoqin@chromium.org changed reviewers: + oshima@chromium.org
not sure if this help, but lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808023003/1
Message was sent while issue was closed.
Description was changed from ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= ========== to ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= ========== to ========== Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= Committed: https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c Cr-Commit-Position: refs/heads/master@{#381635} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c Cr-Commit-Position: refs/heads/master@{#381635}
Message was sent while issue was closed.
On 2016/03/17 01:47:22, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c > Cr-Commit-Position: refs/heads/master@{#381635} Is there anything else that we need to do to deploy new version to bots? Bots still have errors after this. (https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%2...)
Message was sent while issue was closed.
On 2016/03/17 16:10:28, oshima wrote: > On 2016/03/17 01:47:22, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c > > Cr-Commit-Position: refs/heads/master@{#381635} > > Is there anything else that we need to do to deploy new version to bots? > Bots still have errors after this. > (https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%2...) We have to roll DEPS to get Chromium to use the new version. I can take a look at doing that.
Message was sent while issue was closed.
> We have to roll DEPS to get Chromium to use the new version. I can take a look > at doing that. Ignore my last comment. third_party\chromium is in the Chromium repo so no DEPS roll is needed. Testing.
Message was sent while issue was closed.
I think that's all for updating dr. memory, we need debug those failures and errors to figure out why. On Mar 17, 2016 12:10 PM, <oshima@chromium.org> wrote: > On 2016/03/17 01:47:22, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c > > Cr-Commit-Position: refs/heads/master@{#381635} > > Is there anything else that we need to do to deploy new version to bots? > Bots still have errors after this. > ( > https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%2... > ) > > https://codereview.chromium.org/1808023003/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |