Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1808023003: Update Dr. Memory to 0x4c19296, (release 1.10.0) (Closed)

Created:
4 years, 9 months ago by zhaoqin
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Dr. Memory to 0x4c19296, (release 1.10.0) TBR=bruening@chromium.org, oshima@chromium.org BUG= Committed: https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c Cr-Commit-Position: refs/heads/master@{#381635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/drmemory/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/drmemory/drmemory-windows-sfx.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
zhaoqin
4 years, 9 months ago (2016-03-17 00:17:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808023003/1
4 years, 9 months ago (2016-03-17 00:19:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-17 00:19:40 UTC) #5
oshima
not sure if this help, but lgtm
4 years, 9 months ago (2016-03-17 01:02:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808023003/1
4 years, 9 months ago (2016-03-17 01:03:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 01:45:52 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c Cr-Commit-Position: refs/heads/master@{#381635}
4 years, 9 months ago (2016-03-17 01:47:22 UTC) #14
oshima
On 2016/03/17 01:47:22, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 9 months ago (2016-03-17 16:10:28 UTC) #15
brucedawson
On 2016/03/17 16:10:28, oshima wrote: > On 2016/03/17 01:47:22, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-17 18:55:36 UTC) #16
brucedawson
> We have to roll DEPS to get Chromium to use the new version. I ...
4 years, 9 months ago (2016-03-17 19:38:55 UTC) #17
chromium-reviews
4 years, 9 months ago (2016-03-17 21:08:44 UTC) #18
Message was sent while issue was closed.
I think that's all for updating dr. memory, we need debug those failures
and errors to figure out why.
On Mar 17, 2016 12:10 PM, <oshima@chromium.org> wrote:

> On 2016/03/17 01:47:22, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/b8b45d19a6322d1d022c491e8813ee4ed252663c
> > Cr-Commit-Position: refs/heads/master@{#381635}
>
> Is there anything else that we need to do to deploy new version to bots?
> Bots still have errors after this.
> (
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%2...
> )
>
> https://codereview.chromium.org/1808023003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698