Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 18080013: Delete test file with newline problems. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Delete test file with newline problems. The file contains the combinations CRLF LFCR CR and LF, and it looks like git automatically changed them to LF in the last dcommit. See also http://www.dont-panic.cc/capi/2009/02/16/how-to-force-git-to-consider-a-file-as-binary/ The file is going to be added again in a different issue with an additional .gitattributes file to treat it as binary. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15377

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
D test/webkit/parse-backslash-before-newline.js View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL.
7 years, 5 months ago (2013-06-28 11:08:47 UTC) #1
Jakob Kummerow
LGTM. Maybe we should just delete the entire test. You could try to find out ...
7 years, 5 months ago (2013-06-28 11:17:29 UTC) #2
Michael Achenbach
On 2013/06/28 11:17:29, Jakob wrote: > LGTM. > > Maybe we should just delete the ...
7 years, 5 months ago (2013-06-28 11:24:56 UTC) #3
Michael Achenbach
7 years, 5 months ago (2013-06-28 11:25:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15377 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698