Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1807983002: Fix typo in GN's README.md (Closed)

Created:
4 years, 9 months ago by cwallez
Modified:
4 years, 9 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in GN's README.md espeially -> especially BUG=None R=brettw@chromium.org,tfarina@chromium.org Committed: https://crrev.com/a46e260bfd246e6523ae5d38047c21441f94e81b Cr-Commit-Position: refs/heads/master@{#381529}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gn/README.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Corentin Wallez
PTAL, trivial typo fix.
4 years, 9 months ago (2016-03-16 18:50:23 UTC) #2
tfarina
lgtm
4 years, 9 months ago (2016-03-16 19:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807983002/1
4 years, 9 months ago (2016-03-16 19:28:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/157701)
4 years, 9 months ago (2016-03-16 19:41:06 UTC) #10
Corentin Wallez
On 2016/03/16 at 19:41:06, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
4 years, 9 months ago (2016-03-16 19:46:05 UTC) #11
brettw
lgtm
4 years, 9 months ago (2016-03-16 20:10:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807983002/1
4 years, 9 months ago (2016-03-16 20:26:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:48:45 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:50:43 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a46e260bfd246e6523ae5d38047c21441f94e81b
Cr-Commit-Position: refs/heads/master@{#381529}

Powered by Google App Engine
This is Rietveld 408576698