Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1807943002: [fullcodegen] Factor out VisitCallRuntime from archs. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Factor out VisitCallRuntime from archs. This makes the aforementioned visitation function independent of the target architecture by leveraging existing abstractions. R=ishell@chromium.org Committed: https://crrev.com/71ec6ecfff0906efac6589a09968925747b5a18c Cr-Commit-Position: refs/heads/master@{#34833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -426 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -48 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -48 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -48 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -47 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -47 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-16 17:07:53 UTC) #1
Igor Sheludko
lgtm!
4 years, 9 months ago (2016-03-16 17:33:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807943002/1
4 years, 9 months ago (2016-03-16 17:34:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 17:41:13 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:42:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71ec6ecfff0906efac6589a09968925747b5a18c
Cr-Commit-Position: refs/heads/master@{#34833}

Powered by Google App Engine
This is Rietveld 408576698