Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1807893002: Remove swapped out state from RenderFrameImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unreachable code in PrepareRenderViewForNavigation Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 3c94254d30b2302281dbd7fb6a569ea979bc7a15..f74f1a2380e16c0fa7de1abf50059f5529fb7c36 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -225,10 +225,6 @@ class CONTENT_EXPORT RenderFrameImpl
~RenderFrameImpl() override;
- bool is_swapped_out() const {
- return is_swapped_out_;
- }
-
// TODO(nasko): This can be removed once we don't have a swapped out state on
// RenderFrames. See https://crbug.com/357747.
void set_render_frame_proxy(RenderFrameProxy* proxy) {
@@ -626,10 +622,6 @@ class CONTENT_EXPORT RenderFrameImpl
blink::WebFrameSerializerClient::FrameSerializationStatus status)
override;
- // Make this frame show an empty, unscriptable page.
- // TODO(nasko): Remove this method once swapped out state is no longer used.
- void NavigateToSwappedOutURL();
-
// Binds this render frame's service registry.
void BindServiceRegistry(
mojo::shell::mojom::InterfaceProviderRequest services,
@@ -1015,7 +1007,6 @@ class CONTENT_EXPORT RenderFrameImpl
base::WeakPtr<RenderViewImpl> render_view_;
int routing_id_;
- bool is_swapped_out_;
// RenderFrameProxy exists only when is_swapped_out_ is true.
alexmos 2016/03/17 21:41:27 This now talks about a non-existing flag, so maybe
nasko 2016/03/17 23:19:11 Thanks for catching that. Yes, I will look at whet
// TODO(nasko): This can be removed once we don't have a swapped out state on

Powered by Google App Engine
This is Rietveld 408576698