third_party/WebKit/Source/wtf/text/AtomicString.h - Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/AtomicString.h

Issue 1807853003: Deprecate some macros in wtf/Assertions.h in favor of base/logging.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Many updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/wtf/Assertions.h ('K') | « third_party/WebKit/Source/wtf/testing/WTFUnitTestHelpersExport.h ('k') | third_party/WebKit/Source/wtf/text/AtomicString.cpp » ('j') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/AtomicString.h

diff --git a/third_party/WebKit/Source/wtf/text/AtomicString.h b/third_party/WebKit/Source/wtf/text/AtomicString.h

index f0b50327c1a13b5bd7a63231b654e796f5802bc6..df51cda6a7b19068003c1fa8b02e0283e207cb1c 100644

--- a/third_party/WebKit/Source/wtf/text/AtomicString.h

+++ b/third_party/WebKit/Source/wtf/text/AtomicString.h

@@ -24,7 +24,6 @@

#include "wtf/Allocator.h"

#include "wtf/HashTableDeletedValueType.h"

#include "wtf/WTFExport.h"

-#include "wtf/testing/WTFUnitTestHelpersExport.h"

#include "wtf/text/CString.h"

#include "wtf/text/WTFString.h"

#include <iosfwd>

@@ -249,8 +248,8 @@ template<> struct DefaultHash<AtomicString> {

typedef AtomicStringHash Hash;

};

-// Pretty printer for gtest.

-WTF_UNITTEST_HELPERS_EXPORT std::ostream& operator<<(std::ostream&, const AtomicString&);

+// Pretty printer for gtest and base/logging.*.

+WTF_EXPORT std::ostream& operator<<(std::ostream&, const AtomicString&);

} // namespace WTF