Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1807843005: Rebind ChromeVox incremental search to ctrl+f. (Closed)

Created:
4 years, 9 months ago by David Tseng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebind ChromeVox incremental search to ctrl+f. While we have an inaccessible browser find, let ChromeVox take care of find using its incremental search. TEST=ctrl+f brings up i-search. Committed: https://crrev.com/b58331ef11f3c997b4a215e514a03f70f9cd49c3 Cr-Commit-Position: refs/heads/master@{#381738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
David Tseng
4 years, 9 months ago (2016-03-17 01:39:38 UTC) #3
dmazzoni
lgtm
4 years, 9 months ago (2016-03-17 16:43:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807843005/1
4 years, 9 months ago (2016-03-17 16:44:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 17:35:56 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:37:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b58331ef11f3c997b4a215e514a03f70f9cd49c3
Cr-Commit-Position: refs/heads/master@{#381738}

Powered by Google App Engine
This is Rietveld 408576698