Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1807843002: [Binding] Include RuntimeEnabledFeature.h if a dictionary has a RuntimeEnabledFeature (Closed)

Created:
4 years, 9 months ago by peria
Modified:
4 years, 7 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include platform/RuntimeEnabledFeature.h if a dictionary has a runtime enabled feature. Before this CL, recursive inclusion could resolve the reference of RuntimeEnabledFeatures::barEnabled(). BUG=595058 TEST=./Tools/Scripts/run-bindings-tests Committed: https://crrev.com/6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4 Cr-Commit-Position: refs/heads/master@{#381425}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/scripts/v8_dictionary.py View 1 chunk +11 lines, -3 lines 1 comment Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
peria
PTL
4 years, 9 months ago (2016-03-16 06:53:46 UTC) #3
haraken
LGTM
4 years, 9 months ago (2016-03-16 07:09:31 UTC) #4
Yuki
LGTM.
4 years, 9 months ago (2016-03-16 07:15:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807843002/1
4 years, 9 months ago (2016-03-16 07:17:11 UTC) #8
bashi
lgtm. https://codereview.chromium.org/1807843002/diff/1/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py File third_party/WebKit/Source/bindings/scripts/v8_dictionary.py (right): https://codereview.chromium.org/1807843002/diff/1/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py#newcode61 third_party/WebKit/Source/bindings/scripts/v8_dictionary.py:61: for member in members: nit: you can also ...
4 years, 9 months ago (2016-03-16 07:18:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 10:14:13 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 10:15:51 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b8fd364f7c592e921fcfd3fe1783b4e5892c8c4
Cr-Commit-Position: refs/heads/master@{#381425}

Powered by Google App Engine
This is Rietveld 408576698