Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 180783016: Only use devtools category for devtools instrumentation trace events (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Only use devtools category for devtools instrumentation trace events - change PlatformInstrumentation events to use "devtools" as category - change category filter to only include "devtools" BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/inspector/TraceEventDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformInstrumentation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
caseq
6 years, 9 months ago (2014-03-05 14:25:35 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-13 05:25:01 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-13 05:30:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/180783016/1
6 years, 9 months ago (2014-03-13 05:30:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-13 06:12:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_rel
6 years, 9 months ago (2014-03-13 06:12:52 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-18 13:54:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/180783016/1
6 years, 9 months ago (2014-03-18 13:54:57 UTC) #8
caseq
6 years, 9 months ago (2014-03-18 14:04:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r169445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698