chrome/common/extensions/api/commands/commands_manifest_unittest.cc - Issue 180783012: Media Keys should not count towards the max of four shortcuts per extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/commands/commands_manifest_unittest.cc

Issue 180783012: Media Keys should not count towards the max of four shortcuts per extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/commands/commands_handler.cc ('K') | « chrome/common/extensions/api/commands/commands_handler.cc ('k') | chrome/test/data/extensions/manifest_tests/command_should_not_count_media_keys.json » ('j') | chrome/test/data/extensions/manifest_tests/command_should_not_count_media_keys.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/commands/commands_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

index a0eab03ef683cadb6b608345ff1a5582b9f8fd4f..b75300347b7e9b37e288bd9f81a902b9e9f5d826 100644

--- a/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

+++ b/chrome/common/extensions/api/commands/commands_manifest_unittest.cc

@@ -132,4 +132,9 @@ TEST_F(CommandsManifestTest, ChannelTests) {

}

+TEST_F(CommandsManifestTest, CommandManifestShouldNotCountMediaKeys) {

+ scoped_refptr<Extension> extension =

+ LoadAndExpectSuccess("command_should_not_count_media_keys.json");

} // namespace extensions