Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 180783012: Media Keys should not count towards the max of four shortcuts per extension. (Closed)

Created:
6 years, 9 months ago by zhchbin
Modified:
6 years, 9 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Media Keys should not count towards the max of four shortcuts per extension. R=finnur@chromium.org TEST=unit_tests --gtest_filter=CommandsManifestTest.CommandManifestShouldNotCountMediaKeys BUG=329870 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254176

Patch Set 1 #

Total comments: 14

Patch Set 2 : Nits. #

Patch Set 3 : Move IsMediaKey from c/b/e/a/c/command_service.h &&.cc to c/c/e/command.h && .cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -28 lines) Patch
M chrome/browser/extensions/api/commands/command_service.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 2 4 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_mac.mm View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/command.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/command.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/command_should_not_count_media_keys.json View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
zhchbin
Finnur, PTAL. :)
6 years, 9 months ago (2014-02-28 05:31:48 UTC) #1
Finnur
Change the CL description: s/shotcut/shortcut/ https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc File chrome/common/extensions/api/commands/commands_handler.cc (right): https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc#newcode96 chrome/common/extensions/api/commands/commands_handler.cc:96: // We only allow ...
6 years, 9 months ago (2014-02-28 11:02:26 UTC) #2
Finnur
Forgot: ... apart from this, LGTM.
6 years, 9 months ago (2014-02-28 11:02:55 UTC) #3
zhchbin
https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc File chrome/common/extensions/api/commands/commands_handler.cc (right): https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc#newcode96 chrome/common/extensions/api/commands/commands_handler.cc:96: // We only allow media keys to work without ...
6 years, 9 months ago (2014-02-28 11:45:22 UTC) #4
Finnur
https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc File chrome/common/extensions/api/commands/commands_handler.cc (right): https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc#newcode102 chrome/common/extensions/api/commands/commands_handler.cc:102: binding->accelerator().key_code() == ui::VKEY_MEDIA_STOP); I don't see a problem with ...
6 years, 9 months ago (2014-02-28 12:31:00 UTC) #5
zhchbin
https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc File chrome/common/extensions/api/commands/commands_handler.cc (right): https://codereview.chromium.org/180783012/diff/1/chrome/common/extensions/api/commands/commands_handler.cc#newcode102 chrome/common/extensions/api/commands/commands_handler.cc:102: binding->accelerator().key_code() == ui::VKEY_MEDIA_STOP); On 2014/02/28 12:31:00, Finnur wrote: > ...
6 years, 9 months ago (2014-02-28 12:44:20 UTC) #6
Finnur
Yeah, I suspected as much. Actually, this IsMediaKey function should really live in chrome/common/extensions, not ...
6 years, 9 months ago (2014-02-28 12:55:41 UTC) #7
zhchbin
On 2014/02/28 12:55:41, Finnur wrote: > Yeah, I suspected as much. > > Actually, this ...
6 years, 9 months ago (2014-02-28 13:32:36 UTC) #8
Finnur
Yes, this is better. Still LGTM.
6 years, 9 months ago (2014-02-28 14:00:54 UTC) #9
zhchbin
The CQ bit was checked by zhchbin@gmail.com
6 years, 9 months ago (2014-02-28 14:02:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/180783012/40001
6 years, 9 months ago (2014-02-28 14:02:43 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 15:58:06 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=272099
6 years, 9 months ago (2014-02-28 15:58:06 UTC) #13
zhchbin
The CQ bit was checked by zhchbin@gmail.com
6 years, 9 months ago (2014-02-28 15:59:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zhchbin@gmail.com/180783012/40001
6 years, 9 months ago (2014-02-28 15:59:55 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 18:33:38 UTC) #16
Message was sent while issue was closed.
Change committed as 254176

Powered by Google App Engine
This is Rietveld 408576698