MTP Streaming: Optimize block reading

chrome/browser/media_galleries/linux/mtp_device_task_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_galleries/linux/mtp_device_task_helper.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
@@ skipping 15 matching lines @@
 // Does nothing.
 // This method is used to handle the results of
 // MediaTransferProtocolManager::CloseStorage method call.
 void DoNothing(bool error) {
 }
 
 device::MediaTransferProtocolManager* GetMediaTransferProtocolManager() {
   return StorageMonitor::GetInstance()->media_transfer_protocol_manager();
 }
 
+base::File::Info FileInfoFromMTPFileEntry(const MtpFileEntry& file_entry) {
+  base::File::Info file_entry_info;
+  file_entry_info.size = file_entry.file_size();
+  file_entry_info.is_directory =
+      file_entry.file_type() == MtpFileEntry::FILE_TYPE_FOLDER;
+  file_entry_info.is_symbolic_link = false;
+  file_entry_info.last_modified =
+      base::Time::FromTimeT(file_entry.modification_time());
+  file_entry_info.last_accessed = file_entry_info.last_modified;
+  file_entry_info.creation_time = base::Time();
+  return file_entry_info;
+}
+
 }  // namespace
 
 MTPDeviceTaskHelper::MTPDeviceTaskHelper()
     : weak_ptr_factory_(this) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 }
 
 MTPDeviceTaskHelper::~MTPDeviceTaskHelper() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 }
@@ skipping 58 matching lines @@
 
   if (!read_file_worker_)
     read_file_worker_.reset(new MTPReadFileWorker(device_handle_));
   read_file_worker_->WriteDataIntoSnapshotFile(request_info,
                                                snapshot_file_info);
 }
 
 void MTPDeviceTaskHelper::ReadBytes(
     const MTPDeviceAsyncDelegate::ReadBytesRequest& request) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  DCHECK(request.buf);
+  DCHECK(request.buf_len >= 0);
   if (device_handle_.empty()) {
     return HandleDeviceError(request.error_callback,
                              base::File::FILE_ERROR_FAILED);
   }
 
-  GetMediaTransferProtocolManager()->ReadFileChunkByPath(
-      device_handle_,
-      request.device_file_relative_path,
-      base::checked_cast<uint32>(request.offset),
-      base::checked_cast<uint32>(request.buf_len),
-      base::Bind(&MTPDeviceTaskHelper::OnDidReadBytes,
+  GetMediaTransferProtocolManager()->GetFileInfoByPath(
+      device_handle_, request.device_file_relative_path,
+      base::Bind(&MTPDeviceTaskHelper::OnGetFileInfoToReadBytes,
                  weak_ptr_factory_.GetWeakPtr(), request));
 }
 
 void MTPDeviceTaskHelper::CloseStorage() const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (device_handle_.empty())
     return;
   GetMediaTransferProtocolManager()->CloseStorage(device_handle_,
                                                   base::Bind(&DoNothing));
 }
@@ skipping 13 matching lines @@
     const GetFileInfoSuccessCallback& success_callback,
     const ErrorCallback& error_callback,
     const MtpFileEntry& file_entry,
     bool error) const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (error) {
     return HandleDeviceError(error_callback,
                              base::File::FILE_ERROR_NOT_FOUND);
   }
 
-  base::File::Info file_entry_info;
-  file_entry_info.size = file_entry.file_size();
-  file_entry_info.is_directory =
-      file_entry.file_type() == MtpFileEntry::FILE_TYPE_FOLDER;
-  file_entry_info.is_symbolic_link = false;
-  file_entry_info.last_modified =
-      base::Time::FromTimeT(file_entry.modification_time());
-  file_entry_info.last_accessed = file_entry_info.last_modified;
-  file_entry_info.creation_time = base::Time();
-  content::BrowserThread::PostTask(content::BrowserThread::IO,
-                                   FROM_HERE,
-                                   base::Bind(success_callback,
-                                              file_entry_info));
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO,
+      FROM_HERE,
+      base::Bind(success_callback, FileInfoFromMTPFileEntry(file_entry)));
 }
 
 void MTPDeviceTaskHelper::OnDidReadDirectoryByPath(
     const ReadDirectorySuccessCallback& success_callback,
     const ErrorCallback& error_callback,
     const std::vector<MtpFileEntry>& file_entries,
     bool error) const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (error)
     return HandleDeviceError(error_callback, base::File::FILE_ERROR_FAILED);
 
   fileapi::AsyncFileUtil::EntryList entries;
   base::FilePath current;
   MTPDeviceObjectEnumerator file_enum(file_entries);
   while (!(current = file_enum.Next()).empty()) {
     fileapi::DirectoryEntry entry;
     entry.name = fileapi::VirtualPath::BaseName(current).value();
     entry.is_directory = file_enum.IsDirectory();
     entry.size = file_enum.Size();
     entry.last_modified_time = file_enum.LastModifiedTime();
     entries.push_back(entry);
   }
   content::BrowserThread::PostTask(content::BrowserThread::IO,
                                    FROM_HERE,
                                    base::Bind(success_callback, entries));
 }
 
+void MTPDeviceTaskHelper::OnGetFileInfoToReadBytes(
+    const MTPDeviceAsyncDelegate::ReadBytesRequest& request,
+    const MtpFileEntry& file_entry,
+    bool error) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  if (error) {
+    return HandleDeviceError(request.error_callback,
+                             base::File::FILE_ERROR_FAILED);
+  }
+
+  base::File::Info file_info = FileInfoFromMTPFileEntry(file_entry);
+  if (file_info.is_directory) {
+    return HandleDeviceError(request.error_callback,
+                             base::File::FILE_ERROR_NOT_A_FILE);
+  } else if (file_info.size < 0 || file_info.size > kuint32max ||
+             request.offset >= file_info.size) {
+    return HandleDeviceError(request.error_callback,
+                             base::File::FILE_ERROR_FAILED);
+  }
+
+  int bytes_to_read = std::min(
+      request.buf_len,
+      base::checked_cast<int>(file_info.size - request.offset));

[vandebo (ex-Chrome), 2014/02/27 19:32:26]

This changed from saturated_cast to checked_cast...

[tommycli, 2014/02/27 20:18:06]

I changed some of these around. I also added some DCHECKs to MTP_daemon_client.
The comments in the .h file say the chunks are limited to 1MB, but it wasn't
previously enforced.

+
+  GetMediaTransferProtocolManager()->ReadFileChunkByPath(
+      device_handle_,
+      request.device_file_relative_path,
+      base::checked_cast<uint32>(request.offset),
+      base::checked_cast<uint32>(bytes_to_read),
+      base::Bind(&MTPDeviceTaskHelper::OnDidReadBytes,
+                 weak_ptr_factory_.GetWeakPtr(), request, file_info));
+}
+
 void MTPDeviceTaskHelper::OnDidReadBytes(
     const MTPDeviceAsyncDelegate::ReadBytesRequest& request,
+    const base::File::Info& file_info,
     const std::string& data,
     bool error) const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   if (error) {
     return HandleDeviceError(request.error_callback,
                              base::File::FILE_ERROR_FAILED);
   }
 
   CHECK_LE(base::checked_cast<int>(data.length()), request.buf_len);
   std::copy(data.begin(), data.end(), request.buf->data());
 
   content::BrowserThread::PostTask(content::BrowserThread::IO,
                                    FROM_HERE,
                                    base::Bind(request.success_callback,
-                                              data.length()));
+                                              file_info, data.length()));
 }
 
 void MTPDeviceTaskHelper::HandleDeviceError(
     const ErrorCallback& error_callback,
     base::File::Error error) const {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   content::BrowserThread::PostTask(content::BrowserThread::IO,
                                    FROM_HERE,
                                    base::Bind(error_callback, error));
 }