Remove WebGraphicsContext3D dependency in gpu_context_tests.h

Remove WebGraphicsContext3D dependency in gpu_context_tests.h

We make the ContextProviderCommandBuffer and its WebGraphicsContext3D
private in the command buffer version of the tests, and use a
GLInProcessContext in the in-process version. The shared code only is
exposed to GLES2Interface and ContextSupport.

R=kbr@chromium.org
BUG=584497
Committed: https://crrev.com/b73152dbeeba8f1732ea1619eb58612bc6181345
Cr-Commit-Position: refs/heads/master@{#381598}

[danakj, 2016-03-16 01:58:38]

I tried to run the SignalTests in content_browsertests, but they assert for me
with the following. Do you know what I'm doing wrong? Are they supposed to work
on desktop linux debug build?

[35687:35687:0315/185419:1740741104516:FATAL:shell_content_browser_client.cc(140)]
Check failed: !g_browser_client. 
#0 0x7f79ab1a7b0e base::debug::StackTrace::StackTrace()
#1 0x7f79ab2080ef logging::LogMessage::~LogMessage()
#2 0x00000192adae
content::ShellContentBrowserClient::ShellContentBrowserClient()
#3 0x00000190b80d content::ShellMainDelegate::CreateContentBrowserClient()
#4 0x7f79ae2f4c87 content::ContentClientInitializer::Set()
#5 0x7f79ae2f5c81 content::ContentMainRunnerImpl::Initialize()
#6 0x7f79ae2f3b59 content::ContentMain()
#7 0x0000009af697 content::BrowserTestBase::SetUp()
#8 0x0000009c4f1d content::ContentBrowserTest::SetUp()
#9 0x000000ba0f7a
_ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN5media26MockVideoDecodeAcceleratorEMS8_FvvEEEvPT_T0_RKS4_
#10 0x0000019d9c3e testing::internal::HandleExceptionsInMethodIfSupported<>()
#11 0x0000019ceac3 testing::Test::Run()
#12 0x0000019cf2a8 testing::TestInfo::Run()
#13 0x0000019cf84a testing::TestCase::Run()
#14 0x0000019d4bdc testing::internal::UnitTestImpl::RunAllTests()
#15 0x0000019ecaba testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#16 0x0000019db33e testing::internal::HandleExceptionsInMethodIfSupported<>()
#17 0x0000019d487f testing::UnitTest::Run()
#18 0x0000009fe301 RUN_ALL_TESTS()
#19 0x0000009fd37f base::TestSuite::Run()
#20 0x0000009d488c content::ContentTestLauncherDelegate::RunTestSuite()
#21 0x000000af8e82 content::LaunchTests()
#22 0x0000009d46e8 main
#23 0x7f799c9baec5 __libc_start_main

[danakj, 2016-03-16 02:00:07]

On 2016/03/16 01:58:38, danakj wrote:
> I tried to run the SignalTests in content_browsertests, but they assert for me
> with the following. Do you know what I'm doing wrong? Are they supposed to
work
> on desktop linux debug build?
> 
>
[35687:35687:0315/185419:1740741104516:FATAL:shell_content_browser_client.cc(140)]
> Check failed: !g_browser_client. 
> #0 0x7f79ab1a7b0e base::debug::StackTrace::StackTrace()
> #1 0x7f79ab2080ef logging::LogMessage::~LogMessage()
> #2 0x00000192adae
> content::ShellContentBrowserClient::ShellContentBrowserClient()
> #3 0x00000190b80d content::ShellMainDelegate::CreateContentBrowserClient()
> #4 0x7f79ae2f4c87 content::ContentClientInitializer::Set()
> #5 0x7f79ae2f5c81 content::ContentMainRunnerImpl::Initialize()
> #6 0x7f79ae2f3b59 content::ContentMain()
> #7 0x0000009af697 content::BrowserTestBase::SetUp()
> #8 0x0000009c4f1d content::ContentBrowserTest::SetUp()
> #9 0x000000ba0f7a
>
_ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN5media26MockVideoDecodeAcceleratorEMS8_FvvEEEvPT_T0_RKS4_
> #10 0x0000019d9c3e testing::internal::HandleExceptionsInMethodIfSupported<>()
> #11 0x0000019ceac3 testing::Test::Run()
> #12 0x0000019cf2a8 testing::TestInfo::Run()
> #13 0x0000019cf84a testing::TestCase::Run()
> #14 0x0000019d4bdc testing::internal::UnitTestImpl::RunAllTests()
> #15 0x0000019ecaba
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #16 0x0000019db33e testing::internal::HandleExceptionsInMethodIfSupported<>()
> #17 0x0000019d487f testing::UnitTest::Run()
> #18 0x0000009fe301 RUN_ALL_TESTS()
> #19 0x0000009fd37f base::TestSuite::Run()
> #20 0x0000009d488c content::ContentTestLauncherDelegate::RunTestSuite()
> #21 0x000000af8e82 content::LaunchTests()
> #22 0x0000009d46e8 main
> #23 0x7f799c9baec5 __libc_start_main

Oh, they work if I don't use --single_process for the test launcher :/

[Ken Russell (switch to Gerrit), 2016-03-16 02:22:09]

lgtm

[danakj, 2016-03-16 23:29:48]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-16 23:30:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807813002/1

[commit-bot: I haz the power, 2016-03-17 00:12:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 00:14:41]

Description was changed from

==========
Remove WebGraphicsContext3D dependency in gpu_context_tests.h

We make the ContextProviderCommandBuffer and its WebGraphicsContext3D
private in the command buffer version of the tests, and use a
GLInProcessContext in the in-process version. The shared code only is
exposed to GLES2Interface and ContextSupport.

R=kbr@chromium.org
BUG=584497
==========

to

==========
Remove WebGraphicsContext3D dependency in gpu_context_tests.h

We make the ContextProviderCommandBuffer and its WebGraphicsContext3D
private in the command buffer version of the tests, and use a
GLInProcessContext in the in-process version. The shared code only is
exposed to GLES2Interface and ContextSupport.

R=kbr@chromium.org
BUG=584497

Committed: https://crrev.com/b73152dbeeba8f1732ea1619eb58612bc6181345
Cr-Commit-Position: refs/heads/master@{#381598}
==========

[commit-bot: I haz the power, 2016-03-17 00:14:42]

Patchset 1 (id:??) landed as
https://crrev.com/b73152dbeeba8f1732ea1619eb58612bc6181345
Cr-Commit-Position: refs/heads/master@{#381598}