Issue 18078002: Type handling for special cases and optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18078002: Type handling for special cases and optimization (Closed)

Created:
7 years, 5 months ago by danno

Modified:
7 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Type handling for special cases and optimization R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15366

Patch Set 2 : Review feedback #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	src/types.h	View		5 chunks	+6 lines, -2 lines	0 comments	Download
	M	src/types.cc	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with comment https://codereview.chromium.org/18078002/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/18078002/diff/1/src/types.cc#newcode134 src/types.cc:134: if (value->IsTheHole() || value->IsFalse()) return kAny; ...

7 years, 5 months ago (2013-06-27 14:42:11 UTC) #2

danno

Feedback addressed, landing https://codereview.chromium.org/18078002/diff/1/src/types.cc File src/types.cc (right): https://codereview.chromium.org/18078002/diff/1/src/types.cc#newcode134 src/types.cc:134: if (value->IsTheHole() || value->IsFalse()) return kAny; ...

7 years, 5 months ago (2013-06-27 14:44:23 UTC) #3

danno

7 years, 5 months ago (2013-06-27 15:31:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r15366 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18078002: Type handling for special cases and optimization (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review feedback #

Messages