Convert ExtensionInstalledBubble to BubbleDialogDelegateView

chrome/browser/ui/views/extensions/extension_installed_bubble_view.h

Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
index 8eec05bd6383d8be66fa7a269defaea4fa81a83b..0e8be4789d0700829b5fc174bb00cf164ec3b0e0 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
@@ -9,7 +9,7 @@
 #include "chrome/browser/ui/extensions/extension_installed_bubble.h"
 #include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"
 #include "components/bubble/bubble_reference.h"

[msw, 2016/04/07 21:48:58]

nit: remove

[Evan Stade, 2016/04/07 22:43:17]

Done.

-#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/bubble/bubble_dialog_delegate.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/controls/link_listener.h"
 
@@ -35,27 +35,24 @@ class Link;
 //    GENERIC        -> The app menu. This case includes pageActions that don't
 //                      specify a default icon.
 class ExtensionInstalledBubbleView : public BubbleSyncPromoDelegate,
-                                     public views::BubbleDelegateView,
+                                     public views::BubbleDialogDelegateView,
                                      public views::ButtonListener,
                                      public views::LinkListener {
  public:
-  ExtensionInstalledBubbleView(ExtensionInstalledBubble* bubble,
-                               BubbleReference bubble_reference);
+  explicit ExtensionInstalledBubbleView(ExtensionInstalledBubble* bubble);
   ~ExtensionInstalledBubbleView() override;
 
   // Recalculate the anchor position for this bubble.
   void UpdateAnchorView();
 
-  void InitLayout();
-
  private:
-  // views::BubbleDelegateView:
+  Browser* browser() { return controller_->browser(); }
+
+  // views::BubbleDialogDelegateView:
+  void Init() override;
   View* CreateFootnoteView() override;
+  int GetDialogButtons() const override;
   void WindowClosing() override;
-  gfx::Rect GetAnchorRect() const override;
-  void OnWidgetClosing(views::Widget* widget) override;
-  void OnWidgetActivationChanged(views::Widget* widget, bool active) override;
-  bool AcceleratorPressed(const ui::Accelerator& accelerator) override;
 
   // BubbleSyncPromoDelegate:
   void OnSignInLinkClicked() override;
@@ -66,10 +63,7 @@ class ExtensionInstalledBubbleView : public BubbleSyncPromoDelegate,
   // views::ButtonListener:
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
-  const ExtensionInstalledBubble* bubble_;
-  BubbleReference bubble_reference_;
-  const extensions::Extension* extension_;
-  Browser* browser_;
+  ExtensionInstalledBubble* controller_;
   ExtensionInstalledBubble::BubbleType type_;
   ExtensionInstalledBubble::AnchorPosition anchor_position_;