Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: chrome/browser/ui/extensions/extension_installed_bubble.h

Issue 1807793003: Convert ExtensionInstalledBubble to BubbleDialogDelegateView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_ 5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_
6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_ 6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // Provides feedback to the user upon successful installation of an 22 // Provides feedback to the user upon successful installation of an
23 // extension. Depending on the type of extension, the Bubble will 23 // extension. Depending on the type of extension, the Bubble will
24 // point to: 24 // point to:
25 // OMNIBOX_KEYWORD-> The omnibox. 25 // OMNIBOX_KEYWORD-> The omnibox.
26 // BROWSER_ACTION -> The browser action icon in the toolbar. 26 // BROWSER_ACTION -> The browser action icon in the toolbar.
27 // PAGE_ACTION -> A preview of the page action icon in the location 27 // PAGE_ACTION -> A preview of the page action icon in the location
28 // bar which is shown while the Bubble is shown. 28 // bar which is shown while the Bubble is shown.
29 // GENERIC -> The app menu. This case includes page actions that 29 // GENERIC -> The app menu. This case includes page actions that
30 // don't specify a default icon. 30 // don't specify a default icon.
31 // NB: This bubble is using the temporarily-deprecated bubble manager interface
32 // BubbleUi. Do not copy this pattern.
31 class ExtensionInstalledBubble : public BubbleDelegate { 33 class ExtensionInstalledBubble : public BubbleDelegate {
32 public: 34 public:
33 // The behavior and content of this Bubble comes in these varieties: 35 // The behavior and content of this Bubble comes in these varieties:
34 enum BubbleType { 36 enum BubbleType {
35 OMNIBOX_KEYWORD, 37 OMNIBOX_KEYWORD,
36 BROWSER_ACTION, 38 BROWSER_ACTION,
37 PAGE_ACTION, 39 PAGE_ACTION,
38 GENERIC 40 GENERIC
39 }; 41 };
40 42
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 // The location where the bubble should be anchored. 110 // The location where the bubble should be anchored.
109 AnchorPosition anchor_position_; 111 AnchorPosition anchor_position_;
110 112
111 // The command to execute the extension action, if one exists. 113 // The command to execute the extension action, if one exists.
112 std::unique_ptr<extensions::Command> action_command_; 114 std::unique_ptr<extensions::Command> action_command_;
113 115
114 DISALLOW_COPY_AND_ASSIGN(ExtensionInstalledBubble); 116 DISALLOW_COPY_AND_ASSIGN(ExtensionInstalledBubble);
115 }; 117 };
116 118
117 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_ 119 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/extension_installed_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698