Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1807783002: Remove dependency on WebGraphicsContext3D from GLHelper unit tests. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, dcheng, piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@wgc3d-unused
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on WebGraphicsContext3D from GLHelper unit tests. R=kbr@chromium.org BUG=584497 Committed: https://crrev.com/ea80a42043ee4fb565cef829b2914fbda7bb837d Cr-Commit-Position: refs/heads/master@{#381596}

Patch Set 1 #

Patch Set 2 : glhelper-tests: . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -76 lines) Patch
M content/common/gpu/client/gl_helper_unittest.cc View 1 17 chunks +72 lines, -76 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
danakj
4 years, 9 months ago (2016-03-16 01:23:27 UTC) #1
Ken Russell (switch to Gerrit)
LGTM assuming this compiles and passes the trybots. https://codereview.chromium.org/1807783002/diff/20001/content/common/gpu/client/gl_helper_unittest.cc File content/common/gpu/client/gl_helper_unittest.cc (left): https://codereview.chromium.org/1807783002/diff/20001/content/common/gpu/client/gl_helper_unittest.cc#oldcode59 content/common/gpu/client/gl_helper_unittest.cc:59: bool ...
4 years, 9 months ago (2016-03-16 01:34:38 UTC) #2
danakj
https://codereview.chromium.org/1807783002/diff/20001/content/common/gpu/client/gl_helper_unittest.cc File content/common/gpu/client/gl_helper_unittest.cc (left): https://codereview.chromium.org/1807783002/diff/20001/content/common/gpu/client/gl_helper_unittest.cc#oldcode59 content/common/gpu/client/gl_helper_unittest.cc:59: bool lose_context_when_out_of_memory = false; On 2016/03/16 01:34:38, Ken Russell ...
4 years, 9 months ago (2016-03-16 01:44:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807783002/20001
4 years, 9 months ago (2016-03-16 23:30:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 00:10:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 00:11:30 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ea80a42043ee4fb565cef829b2914fbda7bb837d
Cr-Commit-Position: refs/heads/master@{#381596}

Powered by Google App Engine
This is Rietveld 408576698