chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc - Issue 1807743003: Remove HostDesktopType from AppLaunchParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 1807743003: Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp-parent

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | chrome/browser/ui/extensions/app_launch_params.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

index 6c04d0aa249804c3b031842b49d9666cd62a5db0..655883438f89a1763725d2694cc794f6f91f5949 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

@@ -2085,9 +2085,9 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, V1AppNavigation) {

EXPECT_EQ(ash::STATUS_CLOSED, model_->ItemByID(id)->status);

// Create a windowed application.

- AppLaunchParams params(

+ AppLaunchParams params = CreateAppLaunchParamsOverriddenContainer(

profile(), controller_->GetExtensionForAppID(extensions::kWebStoreAppId),

- CURRENT_TAB, chrome::HOST_DESKTOP_TYPE_ASH, extensions::SOURCE_TEST);

+ CURRENT_TAB, extensions::SOURCE_TEST);

params.container = extensions::LAUNCH_CONTAINER_WINDOW;

OpenApplication(params);

EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(id)->status);