chrome/browser/ui/chrome_pages.cc - Issue 1807743003: Remove HostDesktopType from AppLaunchParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 1807743003: Remove HostDesktopType from AppLaunchParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp-parent

Patch Set: cros Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_pages.cc

diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc

index ad3ffeeb84087a2715df9807fe941489a61df82f..6b621f1d342224f14a02e7e358762ab8bea91d17 100644

--- a/chrome/browser/ui/chrome_pages.cc

+++ b/chrome/browser/ui/chrome_pages.cc

@@ -104,9 +104,8 @@ void ShowHelpImpl(Browser* browser,

default:

NOTREACHED() << "Unhandled help source" << source;

}

- AppLaunchParams params(profile, extension, CURRENT_TAB, host_desktop_type,

- app_launch_source);

- OpenApplication(params);

+ OpenApplication(CreateAppLaunchParamsUserContainer(

+ profile, extension, NEW_FOREGROUND_TAB, app_launch_source));

#else

GURL url;

switch (source) {