Remove HostDesktopType from AppLaunchParams

chrome/browser/apps/app_browsertest_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/app_browsertest_util.h"
 
 #include "base/command_line.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
@@ skipping 103 matching lines @@
   const Extension* extension = InstallPlatformApp(name);
 
   LaunchPlatformApp(extension);
 
   app_loaded_observer.Wait();
 
   return extension;
 }
 
 void PlatformAppBrowserTest::LaunchPlatformApp(const Extension* extension) {
-  OpenApplication(AppLaunchParams(browser()->profile(), extension,
-                                  LAUNCH_CONTAINER_NONE, NEW_WINDOW,
-                                  extensions::SOURCE_TEST));
+  OpenApplication(CreateAppLaunchParamsUserContainer(
+      browser()->profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW,

[benwells, 2016/03/16 22:50:12]

Does this compile? I think it should stay as it wsa, as the container is passed
in.

[scottmg, 2016/03/17 00:24:11]

Thanks. I used cs.chromium.org to (attempt to) xref to the correct overrides of
the AppLaunchParams ctors, but when I popped over to my editor I changed the
wrong one (LaunchPlatformApp() instead of LaunchHostedApp()). Reverted here and
fixed below.

+      extensions::SOURCE_TEST));
 }
 
 void PlatformAppBrowserTest::LaunchHostedApp(const Extension* extension) {
   AppLaunchParams launch_params(browser()->profile(), extension,
                                 NEW_FOREGROUND_TAB,
                                 extensions::SOURCE_COMMAND_LINE);
   OpenApplication(launch_params);
 }
 
 WebContents* PlatformAppBrowserTest::GetFirstAppWindowWebContents() {
@@ skipping 121 matching lines @@
   return app_window;
 }
 
 void ExperimentalPlatformAppBrowserTest::SetUpCommandLine(
     base::CommandLine* command_line) {
   PlatformAppBrowserTest::SetUpCommandLine(command_line);
   command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
 }
 
 }  // namespace extensions