Source/bindings/v8/ScriptPromiseTest.cpp - Issue 180773003: Simplify the way to initialize context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptPromiseTest.cpp

Issue 180773003: Simplify the way to initialize context (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptPromiseTest.cpp

diff --git a/Source/bindings/v8/ScriptPromiseTest.cpp b/Source/bindings/v8/ScriptPromiseTest.cpp

index 07153f1a96d0b9be2679f14438845efc2cf1dc79..2eb97f3695a4bdd0e3f7b9b140d7017c99dce011 100644

--- a/Source/bindings/v8/ScriptPromiseTest.cpp

+++ b/Source/bindings/v8/ScriptPromiseTest.cpp

@@ -55,10 +55,8 @@ public:

void SetUp()

{

- v8::Handle<v8::Context> context(m_context.newLocal(m_isolate));

- V8PerContextDataHolder::install(context, DOMWrapperWorld::current(m_isolate));

- m_perContextData = V8PerContextData::create(context);

- m_perContextData->init();

+ // FIXME: Create a new world and pass it to V8PerContextData.

+ m_perContextData = V8PerContextData::create(m_context.newLocal(m_isolate), 0);

}

void TearDown()