Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: Source/bindings/v8/ScriptPromiseResolverTest.cpp

Issue 180773003: Simplify the way to initialize context (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptPromiseResolverTest.cpp
diff --git a/Source/bindings/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/v8/ScriptPromiseResolverTest.cpp
index 41c6cec610a5d3e23aa5c44bd9854922a2dcba0c..8ab80f11b5fe46d30270c0eb0d85f56245de3300 100644
--- a/Source/bindings/v8/ScriptPromiseResolverTest.cpp
+++ b/Source/bindings/v8/ScriptPromiseResolverTest.cpp
@@ -55,10 +55,8 @@ public:
void SetUp()
{
- v8::Handle<v8::Context> context(m_context.newLocal(m_isolate));
- V8PerContextDataHolder::install(context, DOMWrapperWorld::current(m_isolate));
- m_perContextData = V8PerContextData::create(context);
- m_perContextData->init();
+ // FIXME: Create a new world and pass it to V8PerContextData.
haraken 2014/02/28 11:14:05 I'll address this in a follow-up CL. Passing 0 doe
+ m_perContextData = V8PerContextData::create(m_context.newLocal(m_isolate), 0);
m_promise = ScriptPromise::createPending();
m_resolver = ScriptPromiseResolver::create(m_promise);
}

Powered by Google App Engine
This is Rietveld 408576698