MD Settings: Certificate manager, password decryption dialog.

MD Settings: Certificate manager, password decryption dialog.

BUG=547073
Committed: https://crrev.com/b2e7c4fc8d86ee2de5b8b8a11184be35e7fa0c09
Cr-Commit-Position: refs/heads/master@{#381848}

[dpapad, 2016-03-16 17:16:05]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-03-16 17:16:06]

Screenshots at http://imgur.com/a/Kn8gx.

As with previous similar CLs, the dialog is not yet hooked up.

[dpapad, 2016-03-17 18:33:37]

On 2016/03/16 at 17:16:06, dpapad wrote:
> Screenshots at http://imgur.com/a/Kn8gx.
> 
> As with previous similar CLs, the dialog is not yet hooked up.

Friendly ping.

[dschuyler, 2016-03-17 18:47:21]

LGTM w/ nit and question.

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
(right):

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html:17:
i18n-values="label:certificateManagerPassword"
nit: this can be
label="$i18n{certificateManagerPassword}"

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html:24:
<paper-button id="ok" class="action-button" on-tap="onOkTap_" disabled>
Question: can diabled be changed to
disabled$="[[!password_.length]]"
The advantage would be removing the validate_ function.
WDYT

[dpapad, 2016-03-17 21:48:11]

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
(right):

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html:17:
i18n-values="label:certificateManagerPassword"
On 2016/03/17 at 18:47:20, dschuyler wrote:
> nit: this can be
> label="$i18n{certificateManagerPassword}"

Done.

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html:24:
<paper-button id="ok" class="action-button" on-tap="onOkTap_" disabled>
On 2016/03/17 at 18:47:20, dschuyler wrote:
> Question: can diabled be changed to
> disabled$="[[!password_.length]]"
> The advantage would be removing the validate_ function.
> WDYT

Done. In general I tend to prefer as little JS code in HTML files as possible.
Having said that, the Polymer paradigm, is already blurring the lines between
the traditional boundaries (HTML=content, JS=behavior, CSS=presentation).

[dpapad, 2016-03-17 21:48:38]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-03-17 21:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1807703002/#ps80001
(title: "Addressing comment.")

[commit-bot: I haz the power, 2016-03-17 21:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807703002/80001

[Dan Beam, 2016-03-17 21:57:55]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-03-17 21:57:56]

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
(right):

https://codereview.chromium.org/1807703002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html:24:
<paper-button id="ok" class="action-button" on-tap="onOkTap_" disabled>
On 2016/03/17 21:48:11, dpapad wrote:
> On 2016/03/17 at 18:47:20, dschuyler wrote:
> > Question: can diabled be changed to
> > disabled$="[[!password_.length]]"
> > The advantage would be removing the validate_ function.
> > WDYT
> 
> Done. In general I tend to prefer as little JS code in HTML files as possible.
> Having said that, the Polymer paradigm, is already blurring the lines between
> the traditional boundaries (HTML=content, JS=behavior, CSS=presentation).

agreed, this was one of the original reasons I *didn't* advocate for Polymer,
heh

[Dan Beam, 2016-03-17 21:58:04]

lgtm for the presubmit

[commit-bot: I haz the power, 2016-03-18 00:27:48]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-18 00:29:37]

Description was changed from

==========
MD Settings: Certificate manager, password decryption dialog.

BUG=547073
==========

to

==========
MD Settings: Certificate manager, password decryption dialog.

BUG=547073

Committed: https://crrev.com/b2e7c4fc8d86ee2de5b8b8a11184be35e7fa0c09
Cr-Commit-Position: refs/heads/master@{#381848}
==========

[commit-bot: I haz the power, 2016-03-18 00:29:38]

Patchset 5 (id:??) landed as
https://crrev.com/b2e7c4fc8d86ee2de5b8b8a11184be35e7fa0c09
Cr-Commit-Position: refs/heads/master@{#381848}