Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1807673009: [Interpreter] Remove unecessary store of BytecodeArray in CallPrologue. (Closed)

Created:
4 years, 9 months ago by rmcilroy
Modified:
4 years, 9 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove unecessary store of BytecodeArray in CallPrologue. The BytecodeArray shouldn't have changed since it was last loaded from the stack frame, so this store is unecessary. BUG=v8:4280 LOG=N Committed: https://crrev.com/e2b3d0534d23f9e3aec6d40f94de13d07e836df8 Cr-Commit-Position: refs/heads/master@{#34939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/interpreter/interpreter-assembler.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673009/1
4 years, 9 months ago (2016-03-18 18:34:37 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 18:56:48 UTC) #4
rmcilroy
4 years, 9 months ago (2016-03-18 19:15:19 UTC) #6
rmcilroy
Orion, PTAL, thanks.
4 years, 9 months ago (2016-03-18 19:15:32 UTC) #7
oth
lgtm, thanks.
4 years, 9 months ago (2016-03-21 09:45:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673009/1
4 years, 9 months ago (2016-03-21 11:17:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 13:38:48 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 13:39:16 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2b3d0534d23f9e3aec6d40f94de13d07e836df8
Cr-Commit-Position: refs/heads/master@{#34939}

Powered by Google App Engine
This is Rietveld 408576698