Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1807673005: Image filters: fix the zero-sigma fast path in SkBlurImageFilter. (Closed)

Created:
4 years, 9 months ago by Stephen White
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: fix the zero-sigma fast path in SkBlurImageFilter. The fast path was not correctly taking the input srcOffset into account. BUG=595324 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1807673005 Committed: https://skia.googlesource.com/skia/+/bf680c30a280d4d7b3b8d5fedf23defff348cb50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +57 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673005/1
4 years, 9 months ago (2016-03-16 21:30:14 UTC) #3
Stephen White
Robert: PTAL. Thanks!
4 years, 9 months ago (2016-03-16 21:30:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 21:47:03 UTC) #8
robertphillips
lgtm
4 years, 9 months ago (2016-03-16 21:50:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673005/1
4 years, 9 months ago (2016-03-16 23:14:38 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 23:15:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bf680c30a280d4d7b3b8d5fedf23defff348cb50

Powered by Google App Engine
This is Rietveld 408576698