Migrate chrome/browser/net/* to net::IPAddress.

Migrate chrome/browser/net/* to net::IPAddress.

BUG=496258
Committed: https://crrev.com/ea3920faf5dfd8e3f50a99085bcf020978fb7371
Cr-Commit-Position: refs/heads/master@{#381679}

[martijnc, 2016-03-15 21:03:46]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-03-15 21:12:25]

martijn@martijnc.be changed reviewers:
+ eroman@chromium.org

[martijnc, 2016-03-15 22:19:18]

Can you take a look? Thanks!

[eroman, 2016-03-15 22:30:17]

lgtm

https://codereview.chromium.org/1807663002/diff/20001/chrome/browser/net/dns_...
File chrome/browser/net/dns_probe_service.cc (right):

https://codereview.chromium.org/1807663002/diff/20001/chrome/browser/net/dns_...
chrome/browser/net/dns_probe_service.cc:43: bool rv =
dns_ip_address.AssignFromIPLiteral(dns_ip_literal);
We can probably replace this whole thing with something more like:


const uint8_t  kGooglePublicDns1[] = {8, 8, 8, 8};

...

net::IPEndPoint(net::IPAddress(kGooglePublicDns1),
net::dns_protocol::kDefaultPort);


Maybe it is more readable as it is now though, feel free to leave it as you have
it now.

[martijnc, 2016-03-16 19:50:14]

Patchset #2 (id:40001) has been deleted

[martijnc, 2016-03-16 19:52:23]

Patchset #2 (id:60001) has been deleted

[martijnc, 2016-03-16 20:01:04]

Thank you.

https://codereview.chromium.org/1807663002/diff/20001/chrome/browser/net/dns_...
File chrome/browser/net/dns_probe_service.cc (right):

https://codereview.chromium.org/1807663002/diff/20001/chrome/browser/net/dns_...
chrome/browser/net/dns_probe_service.cc:43: bool rv =
dns_ip_address.AssignFromIPLiteral(dns_ip_literal);
On 2016/03/15 at 22:30:17, eroman wrote:
> We can probably replace this whole thing with something more like:
> 
> 
> const uint8_t  kGooglePublicDns1[] = {8, 8, 8, 8};
> 
> ...
> 
> net::IPEndPoint(net::IPAddress(kGooglePublicDns1),
net::dns_protocol::kDefaultPort);
> 
> 
> Maybe it is more readable as it is now though, feel free to leave it as you
have it now.

Done. Seems a good idea to avoid the AssignFromIPliteral call.

[eroman, 2016-03-16 20:25:03]

lgtm

[martijnc, 2016-03-17 09:32:35]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-03-17 09:32:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807663002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807663002/80001

[commit-bot: I haz the power, 2016-03-17 10:09:17]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-17 10:10:12]

Description was changed from

==========
Migrate chrome/browser/net/* to net::IPAddress.

BUG=496258
==========

to

==========
Migrate chrome/browser/net/* to net::IPAddress.

BUG=496258

Committed: https://crrev.com/ea3920faf5dfd8e3f50a99085bcf020978fb7371
Cr-Commit-Position: refs/heads/master@{#381679}
==========

[commit-bot: I haz the power, 2016-03-17 10:10:13]

Patchset 2 (id:??) landed as
https://crrev.com/ea3920faf5dfd8e3f50a99085bcf020978fb7371
Cr-Commit-Position: refs/heads/master@{#381679}