components/test_runner/app_banner_client.h - Issue 1807643002: Make test_runner::AppBannerClient an internal detail of components/test_runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/app_banner_client.h

Issue 1807643002: Make test_runner::AppBannerClient an internal detail of components/test_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self-review... Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/app_banner_client.h

diff --git a/components/test_runner/app_banner_client.h b/components/test_runner/app_banner_client.h

index 0439baf8e42ae4810d8589f7242b875e4ad59081..dfd7798726669a58c97b25563bc418dced849e2e 100644

--- a/components/test_runner/app_banner_client.h

+++ b/components/test_runner/app_banner_client.h

@@ -26,6 +26,10 @@ class TEST_RUNNER_EXPORT AppBannerClient

int requestId,

blink::WebAppBannerCallbacks* callbacks) override;

+ // Resolve the promise associated with the beforeinstallprompt event with the

+ // given |request_id|. The promise is resolved with a result.platform set to

+ // |platform|. If |platform| is not empty, result.outcome will be 'accepted',

+ // otherwise it will be 'dismissed'.

Łukasz Anforowicz 2016/03/15 21:57:28 The comment is moved here from web_test_delegate.h

void ResolvePromise(int request_id, const std::string& platform);

private:

« no previous file with comments | « no previous file | components/test_runner/test_runner.cc » ('j') | components/test_runner/test_runner.cc » ('J')