Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1807623002: Move xfa/include/fxjse/fxjse.h into xfa/fxjse/include. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move xfa/include/fxjse/fxjse.h into xfa/fxjse/include. This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its own file. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3a8051c8cb55e3c108c1f860dc743c42827ae4fa

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -224 lines) Patch
M BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
A fpdfsdk/include/javascript/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 3 chunks +2 lines, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jsapi.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_datawindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_eventpseudomodel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_logpseudomodel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A xfa/fxjse/cfxjse_arguments.h View 1 chunk +25 lines, -0 lines 0 comments Download
M xfa/fxjse/class.h View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxjse/class.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxjse/context.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/dynprop.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + xfa/fxjse/include/fxjse.h View 9 chunks +47 lines, -42 lines 0 comments Download
M xfa/include/fxfa/fxfa_basic.h View 1 chunk +2 lines, -1 line 0 comments Download
D xfa/include/fxjse/fxjse.h View 1 chunk +0 lines, -175 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-15 19:21:54 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-15 19:26:59 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-15 19:42:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3a8051c8cb55e3c108c1f860dc743c42827ae4fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698