Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1807613002: Add MOJO_{BEGIN,END}_EXTERN_C macros, and use them. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -42 lines) Patch
M mojo/public/c/system/buffer.h View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/public/c/system/handle.h View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/public/c/system/macros.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/public/c/system/main.h View 2 chunks +3 lines, -6 lines 0 comments Download
M mojo/public/c/system/message_pipe.h View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/public/c/system/time.h View 3 chunks +4 lines, -6 lines 0 comments Download
M mojo/public/c/system/wait.h View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 9 months ago (2016-03-15 19:31:07 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1807613002/diff/1/mojo/public/c/system/macros.h File mojo/public/c/system/macros.h (right): https://codereview.chromium.org/1807613002/diff/1/mojo/public/c/system/macros.h#newcode65 mojo/public/c/system/macros.h:65: // Use these to declare functions in C ...
4 years, 9 months ago (2016-03-15 19:33:21 UTC) #2
viettrungluu
https://codereview.chromium.org/1807613002/diff/1/mojo/public/c/system/macros.h File mojo/public/c/system/macros.h (right): https://codereview.chromium.org/1807613002/diff/1/mojo/public/c/system/macros.h#newcode65 mojo/public/c/system/macros.h:65: // Use these to declare functions in C header ...
4 years, 9 months ago (2016-03-15 19:37:05 UTC) #3
viettrungluu
4 years, 9 months ago (2016-03-15 19:37:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4a43a9dc94da8d2addee419844b2413bb51203b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698