third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1807603002: Move the grid-column/grid-row shorthands into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1807603002: Move the grid-column/grid-row shorthands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index b36dfdfbd4bdc37d5fd509abb6e86f98706dde0c..b87a204148914974a32109b0dc2de53bb823effd 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -115,7 +115,7 @@ private:

enum TrackSizeRestriction { FixedSizeOnly, AllowAll };

PassRefPtrWillBeRawPtr<CSSValue> parseGridPosition();

bool parseIntegerOrCustomIdentFromGridPosition(RefPtrWillBeRawPtr<CSSPrimitiveValue>& numericValue, RefPtrWillBeRawPtr<CSSCustomIdentValue>& gridLineName);

- bool parseGridItemPositionShorthand(CSSPropertyID, bool important);

+ bool consumeGridItemPositionShorthand(CSSPropertyID, bool important);

PassRefPtrWillBeRawPtr<CSSValue> parseGridTemplateColumns(bool important);

bool parseGridTemplateRowsAndAreasAndColumns(bool important);

bool parseGridTemplateShorthand(bool important);