Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/e9b221f0cf73fdbd4c06ed968fe347c58b865d15
Cr-Commit-Position: refs/heads/master@{#381980}

[rwlbuis, 2016-03-17 16:04:15]

Description was changed from

==========
grid-column shorthand WIP


grid-column WIP

BUG=

patch from issue 1798863005 at patchset 20001
(http://crrev.com/1798863005#ps20001)
==========

to

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-17 16:04:48]

Description was changed from

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[rwlbuis, 2016-03-17 16:42:18]

rob.buis@samsung.com changed reviewers:
+ jfernandez@igalia.com, timloh@chromium.org

[rwlbuis, 2016-03-17 16:42:19]

PTAL, pretty straightforward move I think.

[Timothy Loh, 2016-03-17 23:14:56]

lgtm

https://codereview.chromium.org/1807603002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1807603002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:4462: if
(!m_range.atEnd()) {
I think more regular to do

if (consumeSlash..) {
    endValue = ..
    if (!endValue)
        return false;
} else {
    endValue = ..
}
if (!m_range.atEnd()) // or you could put the !endValue check here
    return false;

Should make it easier to see at a glance that we're properly checking for end of
range in all branches

[rwlbuis, 2016-03-18 14:47:49]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-03-18 14:47:50]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1807603002/#ps60001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-03-18 14:48:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807603002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807603002/60001

[commit-bot: I haz the power, 2016-03-18 15:51:44]

Description was changed from

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

[commit-bot: I haz the power, 2016-03-18 15:51:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-18 15:52:57]

Description was changed from

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780
==========

to

==========
Move the grid-column/grid-row shorthands into CSSPropertyParser

Move the grid-column/grid-row shorthands from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780

Committed: https://crrev.com/e9b221f0cf73fdbd4c06ed968fe347c58b865d15
Cr-Commit-Position: refs/heads/master@{#381980}
==========

[commit-bot: I haz the power, 2016-03-18 15:52:58]

Patchset 4 (id:??) landed as
https://crrev.com/e9b221f0cf73fdbd4c06ed968fe347c58b865d15
Cr-Commit-Position: refs/heads/master@{#381980}