Issue 18076002: Use macros instead of using number directly for x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18076002: Use macros instead of using number directly for x64 (Closed)

Created:
7 years, 5 months ago by weiliang.lin2

Modified:
7 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -9 lines)			Patch
M	src/x64/code-stubs-x64.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

weiliang.lin2

Macro makes it more clear than number and could be also used in X32 code.

7 years, 5 months ago (2013-06-27 14:23:27 UTC) #1

Jakob Kummerow

7 years, 5 months ago (2013-06-28 15:26:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15390 (presubmit successful).