Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: chrome/browser/views/options/cookies_view.cc

Issue 18076: request review: fix issue 2821 and 6132 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/keyword_editor_view.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/cookies_view.cc
===================================================================
--- chrome/browser/views/options/cookies_view.cc (revision 8587)
+++ chrome/browser/views/options/cookies_view.cc (working copy)
@@ -149,14 +149,23 @@
// Domain cookies start with a trailing dot, but we will show this
// in the cookie details, show it without the dot in the list.
std::string& domain = shown_cookies_.at(row)->first;
+ std::wstring wide_domain;
if (!domain.empty() && domain[0] == '.')
- return UTF8ToWide(domain.substr(1));
- return UTF8ToWide(domain);
+ wide_domain = UTF8ToWide(domain.substr(1));
+ else
+ wide_domain = UTF8ToWide(domain);
+ // Force domain to be LTR
+ if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT)
+ l10n_util::WrapStringWithLTRFormatting(&wide_domain);
+ return wide_domain;
}
break;
- case IDS_COOKIES_NAME_COLUMN_HEADER:
- return UTF8ToWide(shown_cookies_.at(row)->second.Name());
+ case IDS_COOKIES_NAME_COLUMN_HEADER: {
+ std::wstring name = UTF8ToWide(shown_cookies_.at(row)->second.Name());
+ l10n_util::AdjustStringForLocaleDirection(name, &name);
+ return name;
break;
+ }
}
NOTREACHED();
return L"";
« no previous file with comments | « chrome/browser/views/keyword_editor_view.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698