Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/views/options/general_page_view.cc

Issue 18076: request review: fix issue 2821 and 6132 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/options/cookies_view.cc ('k') | chrome/browser/views/password_manager_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/general_page_view.cc
===================================================================
--- chrome/browser/views/options/general_page_view.cc (revision 8587)
+++ chrome/browser/views/options/general_page_view.cc (working copy)
@@ -300,6 +300,8 @@
std::wstring CustomHomePagesTableModel::GetText(int row, int column_id) {
DCHECK(column_id == 0);
DCHECK(row >= 0 && row < RowCount());
+ // No need to force URL to have LTR directionality because the custom home
+ // pages control is created using LTR directionality.
return UTF8ToWide(entries_[row].url.spec());
}
« no previous file with comments | « chrome/browser/views/options/cookies_view.cc ('k') | chrome/browser/views/password_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698