third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h - Issue 1807553002: Fix JPEGImageEncoder memory leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h

Issue 1807553002: Fix JPEGImageEncoder memory leak (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp ('k') | third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h

diff --git a/third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h b/third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h

index 45f4aa98a4c5bce33f3f2bf237781083525d9076..9d360ec6a36d225644295d0d37261d761cda521d 100644

--- a/third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h

+++ b/third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h

@@ -59,7 +59,7 @@ public:

// be safer.

static bool encode(const ImageDataBuffer&, const double& quality, Vector<unsigned char>*);

- static void encodeWithPreInitializedState(JPEGImageEncoderState*, const unsigned char*);

+ static bool encodeWithPreInitializedState(PassOwnPtr<JPEGImageEncoderState>, const unsigned char*);

static int computeCompressionQuality(const double& quality);

private: