Host offline status reporting.

remoting/host/server_log_entry.cc

Index: remoting/host/server_log_entry.cc
diff --git a/remoting/host/server_log_entry.cc b/remoting/host/server_log_entry.cc
index f18b2378d2673da82082e78b100c217c6e3ebae4..19c1a07623ef6ff469777e037ea6e324462a819f 100644
--- a/remoting/host/server_log_entry.cc
+++ b/remoting/host/server_log_entry.cc
@@ -26,6 +26,7 @@ const char kLogEntry[] = "entry";
 const char kKeyEventName[] = "event-name";
 const char kValueEventNameSessionState[] = "session-state";
 const char kValueEventNameHeartbeat[] = "heartbeat";
+const char kValueEventNameHostStatus[] = "host-status";
 
 const char kKeyRole[] = "role";
 const char kValueRoleHost[] = "host";
@@ -84,6 +85,14 @@ scoped_ptr<ServerLogEntry> ServerLogEntry::MakeForHeartbeat() {
   return entry.Pass();
 }
 
+// static
+scoped_ptr<ServerLogEntry> ServerLogEntry::MakeForHostStatus() {
+  scoped_ptr<ServerLogEntry> entry(new ServerLogEntry());
+  entry->Set(kKeyRole, kValueRoleHost);
+  entry->Set(kKeyEventName, kValueEventNameHostStatus);
+  return entry.Pass();
+}
+
 void ServerLogEntry::AddHostFields() {
 #if defined(OS_WIN)
   Set(kKeyOsName, kValueOsNameWindows);
@@ -135,6 +144,11 @@ const char* ServerLogEntry::GetValueMode(ServerLogEntry::Mode mode) {
   }
 }
 
+void ServerLogEntry::AddCustomField(const std::string& name,

[rmsousa, 2013/07/09 03:13:41]

Could you pass the host_status and exit_code values as enums in the
MakeForHostStatus() constructor (and translate inside it), rather than adding a
generic key/value setter?

[weitao, 2013/07/09 19:02:17]

I think the ServerLogEntry class should be general purpose and shouldn't need to
know the details (attribute names, etc) of individual log entries created for
different kind of messages. It should be up to the consumers of ServerLogEntry
to add these name/value pairs. 

I am actually planning to submit a separate change to clean this up: hoisting
all the session state and heartbeat specific attribute references up to the
caller.

On 2013/07/09 03:13:41, rmsousa wrote:

+                                    const std::string& value) {
+  Set(name, value);
+}
+
 scoped_ptr<XmlElement> ServerLogEntry::ToStanza() const {
   scoped_ptr<XmlElement> stanza(new XmlElement(QName(
       kChromotingXmlNamespace, kLogEntry)));