Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1807483002:
gpu: Add linux optional GPU tests to presubmit. (Closed)
|
Created:
4 years, 9 months ago by Jamie Madill Modified:
4 years, 8 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Add linux optional GPU tests to presubmit.
Now that this bot is fixed, we should trigger it on gpu changes.
BUG=583702
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/000abd97a1dd0b37fbe424ae23deab0f579fad1a
Cr-Commit-Position: refs/heads/master@{#384375}
Patch Set 1 #
Messages
Total messages: 32 (14 generated)
Description was changed from ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org ========== to ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL. the linux tests fired in the CQ dry run.
Excellent. LGTM
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
jmadill@chromium.org changed reviewers: + piman@chromium.org, sievers@chromium.org
piman or sievers PTAL
lgtm
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Odd.. the failure message was :
Missing LGTM from an OWNER for these files:
third_party/wayland-protocols/src/unstable/scaler/scaler.xml
What should I do about that?
On 2016/03/16 01:14:39, Jamie Madill wrote: > Odd.. the failure message was : > > Missing LGTM from an OWNER for these files: > third_party/wayland-protocols/src/unstable/scaler/scaler.xml > > What should I do about that? Check the bug database to see if it's already filed, and if not, file a P0 bug with go/bug-a-trooper and CC: the Chromium sheriffs.
On 2016/03/16 01:24:09, Ken Russell wrote: > On 2016/03/16 01:14:39, Jamie Madill wrote: > > Odd.. the failure message was : > > > > Missing LGTM from an OWNER for these files: > > third_party/wayland-protocols/src/unstable/scaler/scaler.xml > > > > What should I do about that? > > Check the bug database to see if it's already filed, and if not, file a P0 bug > with go/bug-a-trooper and CC: the Chromium sheriffs. thanks, existing issue was http://crbug.com/595198
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807483002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807483002/1
Message was sent while issue was closed.
Description was changed from ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu: Add linux optional GPU tests to presubmit. Now that this bot is fixed, we should trigger it on gpu changes. BUG=583702 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/000abd97a1dd0b37fbe424ae23deab0f579fad1a Cr-Commit-Position: refs/heads/master@{#384375} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/000abd97a1dd0b37fbe424ae23deab0f579fad1a Cr-Commit-Position: refs/heads/master@{#384375} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
