README.md - Issue 1807463005: luci-go: Improving setup instructions in README.md

Side by Side Diff: README.md

Issue 1807463005: luci-go: Improving setup instructions in README.md (Closed) Base URL: git+ssh://github.com/mithro/luci-go.git@patch-1

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 luci-go: LUCI services and tools in Go	1 luci-go: LUCI services and tools in Go

2 ======================================	2 ======================================

3	3

4 [![GoDoc](https://godoc.org/github.com/luci/luci-go?status.svg)](https://godoc.o rg/github.com/luci/luci-go)	4 [![GoDoc](https://godoc.org/github.com/luci/luci-go?status.svg)](https://godoc.o rg/github.com/luci/luci-go)

5 [![Build Status](https://travis-ci.org/luci/luci-go.svg?branch=master)](https:// travis-ci.org/luci/luci-go)	5 [![Build Status](https://travis-ci.org/luci/luci-go.svg?branch=master)](https:// travis-ci.org/luci/luci-go)

6 [![Coverage Status](https://coveralls.io/repos/luci/luci-go/badge.svg?branch=mas ter&service=github)](https://coveralls.io/github/luci/luci-go?branch=master)	6 [![Coverage Status](https://coveralls.io/repos/luci/luci-go/badge.svg?branch=mas ter&service=github)](https://coveralls.io/github/luci/luci-go?branch=master)

7	7

8 Installing	8 Installing

9 ----------	9 ----------

10	10

	11 [Install go](https://golang.org/doc/install) making sure to set both

	12 `$GOROOT` / `$GOPATH` and adding `$GOROOT/bin:$GOPATH/bin` to your `$PATH`.
	M-A Ruel 2016/03/16 12:50:54 I disagree about recommending to set GOROOT. Norma I disagree about recommending to set GOROOT. Normally you should not have to set it, only GOPATH is needed. The equivalent of GOROOT needs to be added to PATH but that's different. tandrii(chromium) 2016/03/16 15:57:55 hm, I couldn't manage to avoid setting GOROOT myse Show quoted text On 2016/03/16 12:50:54, M-A Ruel wrote: > I disagree about recommending to set GOROOT. Normally you should not have to set > it, only GOPATH is needed. The equivalent of GOROOT needs to be added to PATH > but that's different. hm, I couldn't manage to avoid setting GOROOT myself. The only way I found was installing golang as a package, but version was outdated, and provided little way towards experimenting with newer/different go versions. M-A Ruel 2016/03/16 16:42:58 Ok. I build it myself so I guess I'm an outlier. I Show quoted text On 2016/03/16 15:57:55, tandrii(chromium) wrote: > On 2016/03/16 12:50:54, M-A Ruel wrote: > > I disagree about recommending to set GOROOT. Normally you should not have to > set > > it, only GOPATH is needed. The equivalent of GOROOT needs to be added to PATH > > but that's different. > > hm, I couldn't manage to avoid setting GOROOT myself. The only way I found was > installing golang as a package, but version was outdated, and provided little > way towards experimenting with newer/different go versions. Ok. I build it myself so I guess I'm an outlier. It's literally less than 5 minutes.
	13

11 go get -u github.com/luci/luci-go/client/cmd/...	14 go get -u github.com/luci/luci-go/client/cmd/...

12 go get -u github.com/luci/luci-go/server/cmd/...	15 go get -u github.com/luci/luci-go/server/cmd/...

13	16

14	17

15 Code layout	18 Code layout

16 -----------	19 -----------

17	20

18 * [/appengine/...](https://github.com/luci/luci-go/tree/master/appengine)	21 * [/appengine/...](https://github.com/luci/luci-go/tree/master/appengine)

19 contains [AppEngine](https://cloud.google.com/appengine/docs/go/) server	22 contains [AppEngine](https://cloud.google.com/appengine/docs/go/) server

20 code. It imports packages from `/common/...` and `/server/...`.	23 code. It imports packages from `/common/...` and `/server/...`.

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
57 # hack hack	60 # hack hack

58	61

59 git commit -a -m "This is awesome\nR=joe@example.com"	62 git commit -a -m "This is awesome\nR=joe@example.com"

60 # This will ask for your Google Account credentials.	63 # This will ask for your Google Account credentials.

61 git cl upload -s	64 git cl upload -s

62 # Wait for LGTM over email.	65 # Wait for LGTM over email.

63 # Check the commit queue box in codereview website.	66 # Check the commit queue box in codereview website.

64 # Wait for the change to be tested and landed automatically.	67 # Wait for the change to be tested and landed automatically.

65	68

66 Use `git cl help` and `git cl help <cmd>` for more details.	69 Use `git cl help` and `git cl help <cmd>` for more details.

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »