Description was changed from ========== [Autofill] Add cvc regexes for the heuristics. Added the following ...
4 years, 9 months ago
(2016-03-15 22:06:14 UTC)
#1
Description was changed from
==========
[Autofill] Add cvc regexes for the heuristics.
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
==========
to
==========
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
==========
4 years, 9 months ago
(2016-03-15 23:22:48 UTC)
#3
PTAL?
Mathieu
On 2016/03/15 at 23:22:48, sebsg wrote: > PTAL? where is the 141 file? Also I ...
4 years, 9 months ago
(2016-03-15 23:26:39 UTC)
#4
On 2016/03/15 at 23:22:48, sebsg wrote:
> PTAL?
where is the 141 file? Also I noticed we have one starting with 27_, it should
be 027_
otherwise lgtm
sebsg
On 2016/03/15 23:26:39, Mathieu Perreault wrote: > On 2016/03/15 at 23:22:48, sebsg wrote: > > ...
4 years, 9 months ago
(2016-03-15 23:29:38 UTC)
#5
On 2016/03/15 23:26:39, Mathieu Perreault wrote:
> On 2016/03/15 at 23:22:48, sebsg wrote:
> > PTAL?
>
> where is the 141 file? Also I noticed we have one starting with 27_, it should
> be 027_
>
> otherwise lgtm
You are right. Both the file 141 and the switch from 27_ to 140 (027 is already
taken) are in another CL. Do you want me to move these changes here? Thanks!
Mathieu
On 2016/03/15 at 23:29:38, sebsg wrote: > On 2016/03/15 23:26:39, Mathieu Perreault wrote: > > ...
4 years, 9 months ago
(2016-03-15 23:47:55 UTC)
#6
On 2016/03/15 at 23:29:38, sebsg wrote:
> On 2016/03/15 23:26:39, Mathieu Perreault wrote:
> > On 2016/03/15 at 23:22:48, sebsg wrote:
> > > PTAL?
> >
> > where is the 141 file? Also I noticed we have one starting with 27_, it
should
> > be 027_
> >
> > otherwise lgtm
>
> You are right. Both the file 141 and the switch from 27_ to 140 (027 is
already taken) are in another CL. Do you want me to move these changes here?
Thanks!
sure let's combine them!
sebsg
Done!
4 years, 9 months ago
(2016-03-16 16:17:54 UTC)
#7
Done!
sebsg
The CQ bit was checked by sebsg@chromium.org
4 years, 9 months ago
(2016-03-16 16:18:01 UTC)
#8
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807463003/20001
4 years, 9 months ago
(2016-03-16 16:18:18 UTC)
#10
Description was changed from ========== Added the following cvc regexes to make the heuristics work ...
4 years, 9 months ago
(2016-03-16 18:00:28 UTC)
#11
Message was sent while issue was closed.
Description was changed from
==========
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
==========
to
==========
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago
(2016-03-16 18:00:29 UTC)
#12
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
commit-bot: I haz the power
Description was changed from ========== Added the following cvc regexes to make the heuristics work ...
4 years, 9 months ago
(2016-03-16 18:03:22 UTC)
#13
Message was sent while issue was closed.
Description was changed from
==========
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
==========
to
==========
Added the following cvc regexes to make the heuristics work on sites of the top
100.
"security.?number", "card.?pin" and "c-v-v"
to fix net-a-porter.com, efollet.com and m.jcp.com respectively.
BUG=595096
TEST=FormStructureBrowserTest
Committed: https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6
Cr-Commit-Position: refs/heads/master@{#381493}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6 Cr-Commit-Position: refs/heads/master@{#381493}
4 years, 9 months ago
(2016-03-16 18:03:23 UTC)
#14
Issue 1807463003: [Autofill] Add cvc regexes for the heuristics.
(Closed)
Created 4 years, 9 months ago by sebsg
Modified 4 years, 9 months ago
Reviewers: Mathieu
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0