Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1807463003: [Autofill] Add cvc regexes for the heuristics. (Closed)

Created:
4 years, 9 months ago by sebsg
Modified:
4 years, 9 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the following cvc regexes to make the heuristics work on sites of the top 100. "security.?number", "card.?pin" and "c-v-v" to fix net-a-porter.com, efollet.com and m.jcp.com respectively. BUG=595096 TEST=FormStructureBrowserTest Committed: https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6 Cr-Commit-Position: refs/heads/master@{#381493}

Patch Set 1 #

Patch Set 2 : Changed test file name #

Messages

Total messages: 14 (6 generated)
sebsg
PTAL?
4 years, 9 months ago (2016-03-15 23:22:48 UTC) #3
Mathieu
On 2016/03/15 at 23:22:48, sebsg wrote: > PTAL? where is the 141 file? Also I ...
4 years, 9 months ago (2016-03-15 23:26:39 UTC) #4
sebsg
On 2016/03/15 23:26:39, Mathieu Perreault wrote: > On 2016/03/15 at 23:22:48, sebsg wrote: > > ...
4 years, 9 months ago (2016-03-15 23:29:38 UTC) #5
Mathieu
On 2016/03/15 at 23:29:38, sebsg wrote: > On 2016/03/15 23:26:39, Mathieu Perreault wrote: > > ...
4 years, 9 months ago (2016-03-15 23:47:55 UTC) #6
sebsg
Done!
4 years, 9 months ago (2016-03-16 16:17:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807463003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807463003/20001
4 years, 9 months ago (2016-03-16 16:18:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 18:00:29 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 18:03:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c17f62a8425b4e4547255495073e673312a86b6
Cr-Commit-Position: refs/heads/master@{#381493}

Powered by Google App Engine
This is Rietveld 408576698