Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1807433002: [Tracing] Remove TRACE_EVENT_SCOPED_CONTEXT from V8 temporarily (Closed)

Created:
4 years, 9 months ago by fmeawad
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tracing] Remove TRACE_EVENT_SCOPED_CONTEXT from V8 temporarily The current trace scoping failed to accomplish what it intended to do it failed in 2 aspects: First, when new trace events were added in https://codereview.chromium.org/1770353002/ they escaped the scopes. Secondly, a webgl code interacts with the V8 Objects directly using the EXECUTION_PRIMITIVE context that does not generate any TRACE_EVENTs resulting in a lot of empty scopes (breaking analysis on TBM webgl benchmarks) https://crbug.com/590761. I am removing the calls for now until figuring out a better approach for both issues. BUG=590761, v8:4565 LOG=N Committed: https://crrev.com/7a7d5815dbe292c587d696b963409af746e5bd9a Cr-Commit-Position: refs/heads/master@{#34799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/api.cc View 8 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807433002/1
4 years, 9 months ago (2016-03-15 15:46:52 UTC) #2
fmeawad
PTAL.
4 years, 9 months ago (2016-03-15 15:46:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 16:06:43 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-15 20:27:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807433002/1
4 years, 9 months ago (2016-03-15 20:42:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 20:45:00 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 20:46:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a7d5815dbe292c587d696b963409af746e5bd9a
Cr-Commit-Position: refs/heads/master@{#34799}

Powered by Google App Engine
This is Rietveld 408576698