Ensure DOMWrapperWorld always exists in all webkit_unit_tests

Ensure DOMWrapperWorld always exists in all webkit_unit_tests

Currently DOMWrapperWorld can be 0 in some tests. This is problematic since I want to make DOMWrapperWorld::current() callable from anywhere. Thus this CL adds DOMWrapperWorld to all webkit_unit_tests.

- It's verbose to initialize v8::HandleScope, v8::Context, v8::Context::Scope, V8PerContextData and DOMWrapperWorld in each test. So this CL adds a helper class (V8BindingTestScope) that does all the initialization work.

- This CL also fixes indentation of V8Binding.h.

BUG=341032
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168355

R=dcarney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168376

[haraken, 2014-03-03 12:33:09]

PTAL

Regarding V8Binding.h, please just take a look at V8BindingTestScope. Other
diffs are just fixing indentation.

[dcarney, 2014-03-03 12:48:32]

lgtm

[haraken, 2014-03-03 12:58:36]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-03 12:58:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/1

[commit-bot: I haz the power, 2014-03-03 16:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 16:39:51]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[haraken, 2014-03-03 23:19:25]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-03 23:25:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/1

[commit-bot: I haz the power, 2014-03-03 23:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 23:25:18]

Failed to apply patch for Source/bindings/v8/WorkerScriptController.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/v8/WorkerScriptController.cpp
  Hunk #1 FAILED at 69.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/v8/WorkerScriptController.cpp.rej

Patch:       Source/bindings/v8/WorkerScriptController.cpp
Index: Source/bindings/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/v8/WorkerScriptController.cpp
b/Source/bindings/v8/WorkerScriptController.cpp
index
47beee655dd03a9e744052230f6d813b0ab1d206..2cf195ccbec1c989f166c1342996ceb2bcbd3214
100644
--- a/Source/bindings/v8/WorkerScriptController.cpp
+++ b/Source/bindings/v8/WorkerScriptController.cpp
@@ -69,7 +69,7 @@
WorkerScriptController::WorkerScriptController(WorkerGlobalScope& workerGlobalSc
     v8::V8::Initialize();
     m_isolateHolder = adoptPtr(new gin::IsolateHolder(isolate,
v8ArrayBufferAllocator()));
     V8PerIsolateData::ensureInitialized(isolate);
-    m_world = DOMWrapperWorld::create(WorkerWorldId, -1);
+    m_world = DOMWrapperWorld::create(WorkerWorldId);
     m_interruptor = adoptPtr(new V8IsolateInterruptor(isolate));
     ThreadState::current()->addInterruptor(m_interruptor.get());
 }

[haraken, 2014-03-04 00:54:42]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/20001

[haraken, 2014-03-04 00:55:57]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:56:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/40001

[haraken, 2014-03-04 03:39:05]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2014-03-04 03:39:18]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-04 03:39:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/40001

[commit-bot: I haz the power, 2014-03-04 03:40:06]

Change committed as 168355

[apavlov, 2014-03-04 07:59:29]

A revert of this CL has been created in
https://codereview.chromium.org/183803017/ by apavlov@chromium.org.

The reason for reverting is: A few inspector tests are crashing:
WebCore::DOMWrapperWorld::ensureIsolatedWorld(int, int) [DOMWrapperWorld.cpp :
124 + 0x33].

[haraken, 2014-03-04 09:02:44]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-03-04 09:02:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/180743013/40002

[haraken, 2014-03-04 09:03:16]

On 2014/03/04 07:59:29, apavlov wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/183803017/ by mailto:apavlov@chromium.org.
> 
> The reason for reverting is: A few inspector tests are crashing:
> WebCore::DOMWrapperWorld::ensureIsolatedWorld(int, int) [DOMWrapperWorld.cpp :
> 124 + 0x33].

Thanks for reverting. I fixed the failure and relanding the CL via a commit
queue.

[haraken, 2014-03-04 10:55:41]

Committed patchset #4 manually as r168376 (presubmit successful).