Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 180743011: Add blink_test_support target. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add blink_test_support target. This target will replace the current blink_web_test_support target. But we need to add it first, then change Chromium to use, just after that we will be able to remove blink_web_test_support from blink.gyp. In fact webkit_test_support after this three side change lands, webkit_test_support will actually be renamed to blink_web_test_support. BUG=None TEST=content_unittests, blink_tests R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M public/blink.gyp View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Adam, this is my plan. PTAL. Thanks!
6 years, 9 months ago (2014-03-03 05:18:19 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-03 06:41:45 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-03 14:35:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/180743011/1
6 years, 9 months ago (2014-03-03 14:36:04 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-03 15:52:41 UTC) #5
Message was sent while issue was closed.
Change committed as 168315

Powered by Google App Engine
This is Rietveld 408576698