Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 180743009: Merged r19535, r19549, r19584 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)
Modified:
6 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Merged r19535, r19549, r19584 into 3.24 branch. Fix for a smi stores optimization on x64 with a regression test. Fix for failing asserts in HBoundsCheck code generation on x64: index register should be zero extended. Handle arguments objects in frame when materializing arguments BUG=345715, 345820, 347262 LOG=N R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -36 lines) Patch
M src/deoptimizer.h View 3 chunks +18 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 7 chunks +26 lines, -17 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-gap-resolver-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-347262.js View 1 chunk +31 lines, -11 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-345715.js View 1 chunk +26 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-345820.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
6 years, 9 months ago (2014-02-28 13:14:31 UTC) #1
danno
Rubber stamp LGTM.
6 years, 9 months ago (2014-02-28 13:17:13 UTC) #2
Hannes Payer (out of office)
6 years, 9 months ago (2014-02-28 13:18:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19611.

Powered by Google App Engine
This is Rietveld 408576698