Issue 18074004: RefPtr Node since it can be blown away in load event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18074004: RefPtr Node since it can be blown away in load event. (Closed)

Created:
7 years, 5 months ago by inferno

Modified:
7 years, 5 months ago

Reviewers:
aarya, abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

RefPtr Node since it can be blown away in load event. BUG=249199 TEST=No test since it is blocked on an unrelated v8 exception. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153161

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	Source/core/editing/ApplyStyleCommand.cpp	View		2 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/inferno@chromium.org/18074004/1

7 years, 5 months ago (2013-06-27 17:09:25 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=14163

7 years, 5 months ago (2013-06-27 18:02:37 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/inferno@chromium.org/18074004/1

7 years, 5 months ago (2013-06-27 18:04:12 UTC) #5

inferno

7 years, 5 months ago (2013-06-27 18:07:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r153161 (presubmit successful).

Expand Messages | Collapse Messages