Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1807373002: Reduce size of several PDFium constant tables. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com, jschuh
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reduce size of several PDFium constant tables. Either by using the smallest possible data type, or By accurately calcuating the bounds, or Moving to array of pointers for varying length rows. Notes: The 929 is reassuring since PDF417 barcode uses GF(929). FX_WCHAR is 4 bytes on unix (2 on windows). Binary looks to be about 240k smaller on linux/64 R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/314743a4a752716b8e977482ad6c757c70d019db

Patch Set 1 #

Patch Set 2 : Found another one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -160 lines) Patch
M core/fpdftext/unicodenormalization.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdftext/unicodenormalizationdata.h View 1 chunk +6 lines, -6 lines 0 comments Download
M core/fpdftext/unicodenormalizationdata.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_ErrorCorrection.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/fxbarcode/datamatrix/BC_ErrorCorrection.cpp View 1 1 chunk +74 lines, -39 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417CodewordDecoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417CodewordDecoder.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Common.h View 1 chunk +10 lines, -10 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417Common.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417ErrorCorrection.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxbarcode/pdf417/BC_PDF417ErrorCorrection.cpp View 3 chunks +99 lines, -74 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Oliver, for review.
4 years, 9 months ago (2016-03-18 00:02:32 UTC) #3
Oliver Chang
lgtm
4 years, 9 months ago (2016-03-18 01:14:31 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-18 16:32:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
314743a4a752716b8e977482ad6c757c70d019db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698